Skip to content

Conversation

@daanniill
Copy link
Contributor

@daanniill daanniill commented Nov 2, 2025

Overview

Resolves #863

Deploy Preview: https://deploy-preview-870--jovial-pasteur-581b4a.netlify.app/

Changes

  • Added a new “Website Made By” section in components/Footer.js
  • Moved some of the for the FooterLinkElement component to the footer scss module
  • Integrated the developer team logo (linked dynamically from footerInitiativeLinks)
  • Fixed placeholder link width issue when initiative image is missing.
  • No new dependencies needed

Testing

  • Scroll down to bottom of main page and view new header and logo under REACH US AT
Screenshot 2025-11-01 at 8 08 03 PM

Possible Changes

  • add hover animations to all the logos (e.g.: make the logo bigger when hovered)

Checklist

  • Code follows the project's style guidelines.
  • Documentation has been updated where necessary.
  • All checks pass and deploy builds with no errors.

@smalex-z smalex-z requested a review from nathanzhang1 November 3, 2025 17:54
Copy link
Contributor

@nathanzhang1 nathanzhang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some pointers, but otherwise looks good to me:

  1. Made By --> Website Made By
  2. Let's keep styles consistently on the SCSS module of whatever component we are working on instead of writing them inline, which can appear bloated. See if you can rewrite the styles into Footer.module.scss WHERE POSSIBLE for the FooterLinkElement that you added and the longer one below (line 165).

…oterLinkElement to Footer SCSS. Fixed placeholder link width issue when initiative image is missing.
@daanniill
Copy link
Contributor Author

@nathanzhang1 Should be all good now, thank you for the pointers:)

@smalex-z smalex-z requested a review from nathanzhang1 November 5, 2025 21:29
Copy link
Contributor

@nathanzhang1 nathanzhang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks so much, feel free to go ahead and merge

@daanniill daanniill merged commit 25f383d into main Nov 7, 2025
8 checks passed
@daanniill daanniill deleted the fix/863-add-dev-team-credit branch November 7, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Dev Team Credit

3 participants