Minor Layer Mods #42
Open
Minor Layer Mods #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e logic in my other branch (Praveen-VisionStackTests) can create a publisher with the name of this layer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the code review for another PR I made (#41 (comment)), Daniel mentioned that small changes to the layer scripts can be made into a PR.
I'm guessing that's because the layer scripts are such a huge component, so it's better to separate something like that from my development of the test script to make it easier to track down bugs.
I made 2 small changes:
UnderwaterEnhancementLayer.pyscript. (Actually, Daniel might've made this change from my account when I was asking about VisionStack in the lab).NormalizationLayer.pyscript just so my publisher name logic in my other branch (Test Script for Vision Stack #41 (comment)) can create a proper name for this layer's publisher.