Fix _dump_float producing invalid TOML for Decimal special values#454
Open
bysiber wants to merge 1 commit intouiri:masterfrom
Open
Fix _dump_float producing invalid TOML for Decimal special values#454bysiber wants to merge 1 commit intouiri:masterfrom
bysiber wants to merge 1 commit intouiri:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_dump_floatproduces invalid TOML when encodingDecimalspecial values (Infinity,-Infinity,NaN).Problem
_dump_floatuses"{}".format(v)to convert numeric values to strings. Forfloat, Python produces lowercaseinf/nanwhich matches TOML's expected format. But forDecimal, Python producesInfinity/NaN(capitalized), which is not valid TOML:Since
_dump_floatis registered indump_funcsfor bothfloatandDecimal, it needs to handle both formats.Fix
Normalize
Infinity→inf,-Infinity→-inf, andNaN→nanin_dump_floatbefore applying the exponent formatting. This covers bothfloatandDecimalinputs.