Merged
Conversation
Contributor
Nealium104
commented
Nov 3, 2025
Nealium104
commented
- Adds tooling for testing (phpunit), future php upgrades (rector), and linting (php code sniffer)
- Adds CI for repo
- Adds a publish pipeline. If a merge completes to dev, a new version of the package should automatically push to ghcr
- Integrates rector PHP changes (stylistic changes only)
- Makes a new stage, CI in the Dockerfile
- Adds a very basic test
added 9 commits
October 31, 2025 14:05
Contributor
Author
|
An important note: Linting will fail until addressed. Build and unit-test should be considered gates, but linting is just for style. I will make an issue to address the linting errors as future work. #12 |
nrsa222
reviewed
Nov 3, 2025
.github/workflows/publish.yml
Outdated
| context: . | ||
| push: true | ||
| tags: | | ||
| ghcr.io/${{ github.repository_owner }}/exploreuk-web-app:${{ github.event.workflow_run.head_sha }} |
Contributor
There was a problem hiding this comment.
It looks like this image is being published to exploreuk-web-app, but it should be published to it's own package repo and then managed as a dependency by the exploreuk-web-app project.
Contributor
Author
There was a problem hiding this comment.
Silly mistake. Fixed.
nrsa222
previously approved these changes
Nov 4, 2025
nrsa222
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.