Conversation
- Adjusted video-rs dependency to allow versions >=0.10.5 and <0.12.
- Introduced video-runtime feature for internal video handling.
- Separated video support into two features: video for FFmpeg 8+
and video-ffmpeg7 for FFmpeg 7 with video-rs 0.10.x.
- Retained ndarray 0.16 as an optional dependency for video-ffmpeg7.
Signed-off-by: Onuralp SEZER <onuralp@ultralytics.com>
Signed-off-by: Onuralp SEZER <onuralp@ultralytics.com>
|
👋 Hello @onuralpszr, thank you for submitting a
|
Signed-off-by: Onuralp SEZER <onuralp@ultralytics.com>
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Good direction on separating FFmpeg 8 and FFmpeg 7 feature paths, but the current feature gating is not enforceable with a single ranged video-rs dependency. As written, video-ffmpeg7 can still pick video-rs 0.11, so the compatibility path is not guaranteed.
💬 Posted 1 inline comment
📋 Skipped 1 file (lock files, generated, images, etc.)
Cargo.lock
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: Onuralp SEZER <onuralp@ultralytics.com>
Signed-off-by: Onuralp SEZER <onuralp@ultralytics.com>
Signed-off-by: Onuralp SEZER <onuralp@ultralytics.com>
Signed-off-by: Onuralp SEZER <onuralp@ultralytics.com>
|
🎉 Huge congratulations on getting this merged — what an excellent improvement to Big thanks to @onuralpszr for driving this forward, and to @artest08 and @fcakyon for the valuable contributions along the way 🙌
This PR is a perfect example of that: cleaner dependencies, stronger cross-platform CI, clearer docs, and smoother FFmpeg support all combine into a major reliability win for everyone building video-enabled inference pipelines. Really impactful work — thank you all! 🚀 |
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
This PR upgrades and simplifies video support across CI, dependencies, and docs by standardizing around FFmpeg 8 (while keeping FFmpeg 7 compatibility), reducing Rust video-related dependency complexity, and improving build/test reliability 🚀🎬.
📊 Key Changes
ffmpeg@7to standardffmpeg(FFmpeg 8 path), removing manual env var setup for cleaner builds 🍎apt, and includesvisualizein coverage features 📈videofeature was simplified:ffmpeg-next,ffmpeg-sys-next, and customndarray_0_16feature wiringvideo-rsonly (with a broader compatible version range) 🔧video_rs::ffmpeg/video_rs::ffmpeg::ffiinstead of direct ffmpeg crates 🧩--features videofor enabling video support 📝🎯 Purpose & Impact
video-rsabstraction 🛠️ultralytics/inferencewith modern FFmpeg stacks 🎥📋 Skipped 1 file (lock files, generated, images, etc.)
Cargo.lock