Collection children: A slim navigation of collection children + higher take above target #20641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslyngsoe
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes tree expansion behavior by refactoring the target child loading logic. The changes reduce initial page size for document collections in menus and improve the efficiency of child loading by avoiding unnecessary reloads.
- Changed initial page size for document collections from 2 to 1 item
- Moved target-already-loaded check from expansion manager to children manager's
loadChildren()method - Changed default takeBefore value to use the target pagination take size instead of hardcoded 5
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| document-tree-item.context.ts | Reduces setTargetTakeSize from (2,2) to (1,1) for collections in menu mode |
| tree-item-expansion.manager.ts | Removes target-already-loaded check, delegating this responsibility to children manager |
| tree-item-children.manager.ts | Adds target-already-loaded check at start of loadChildren() and changes default takeBefore fallback from hardcoded 5 to use getTakeSize() |
src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-children.manager.ts
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/core/tree/tree-item/tree-item-children.manager.ts
Show resolved
Hide resolved
madsrasmussen
approved these changes
Oct 31, 2025
nielslyngsoe
deleted the
v17/hotfix/improve-collection-children-navigation
branch
nielslyngsoe
added a commit
that referenced
this pull request
Oct 31, 2025
…r take above target (#20641) * enforce update of children when collection * only load one above and below collection children * take 50 above a target for default experience * revert reset target * remove old impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When navigating to another item of a Collection via the tree (or the Collection), we only display 1 item above and 1 below.
And when deep linking, we extended items above from 5 to 50.