Icon picker: Better title for icon colors

[bjarnef]

Prerequisites

• I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

This improves the titles for icon colors - especially the title for text color, which isn't meaningful although the alias makes sense in code.

[github-actions]

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[Copilot]

Pull Request Overview

This PR improves the user-facing display of icon color names in the icon picker modal, making them more meaningful and user-friendly.

Key Changes:

• Added a name property to each color in the umbracoColors array with human-readable labels
• Updated the icon picker modal to display the new name property instead of the technical alias

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/Umbraco.Web.UI.Client/src/packages/core/resources/extractUmbColorVariable.function.ts	Added name property to color objects with user-friendly labels (e.g., "Black" for "text" alias, "Light Blue" for "light-blue" alias)
src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icon-picker-modal/icon-picker-modal.element.ts	Updated color swatch label and title to use the new name property with fallback to alias

[AndyButland]

Thanks for the updates @bjarnef - I've tested and all works as expected and improves what we had before.

I had a further thought thought (and sorry I didn't consider this first time around).

Perhaps it would be better still if these were localised. What do you think? Seems you could implement that by removing the name again, using the alias to define a label key, and then localise with label=${this.localize.term('colors_' + toCamelCase(color.alias))}. You could then create translation keys for the non-legacy colours.

[bjarnef]

@AndyButland I have updated the colors to use the translations. I also added black and white as these are common :)

Then we just need the ability to hide colors too as in the old backoffice: #20650

Regarding the icon picker I added a few other suggestions like being able to configure the colors/swatches (at least when extending the icon picker / using the icon picker modal): #20647
For now I have a separate settings property to control icon color with brand colors.

[AndyButland]

Thanks @bjarnef - works nicely now, so have approved and we can expect this in 17.1. We'll hold merging for now until we switch main to match the 17 branch, so we don't confusingly have this for 16.4 and not 17.0.

[bjarnef]

@AndyButland is it a mistake the toCamelCase is imported differently here?

Umbraco-CMS/src/Umbraco.Web.UI.Client/src/packages/core/utils/string/generate-umbraco-alias/generate-umbraco-alias.function.ts

Line 1 in 1f82bdd

import { toCamelCase } from '../to-camel-case/index.js';

[AndyButland]

I don't think so. Not really my area of expertise but I could see the front-end build broke when we had the import like this in the file you were working on, so I changed it to import via the package. In the case you've shown, here we we are in the code for the "utils" package, hence it's correct to use a local file reference import.