Skip to content

Add option to hide colors from icon picker #20650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+39 −21
Open

Add option to hide colors from icon picker #20650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e6bc9a
Add option to hide colors from icon picker
bjarnef Oct 25, 2025
c71af43
Hide colors
bjarnef Oct 25, 2025
65a2109
Hide colors from config
bjarnef Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 27 additions & 20 deletions ....UI.Client/src/packages/core/icon-registry/icon-picker-modal/icon-picker-modal.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,26 +81,7 @@ export class UmbIconPickerModalElement extends UmbModalBaseElement<UmbIconPicker
<umb-body-layout headline=${this.localize.term('defaultdialogs_selectIcon')}>
<div id="container">
${this.renderSearch()}
<hr />
<uui-color-swatches
value=${ifDefined(this.value.color)}
label=${this.localize.term('defaultdialogs_colorSwitcher')}
@change=${this.#onColorChange}>
${
// TODO: Missing localization for the color aliases. [NL]
this._colorList.map(
(color) => html`
<uui-color-swatch
label=${color.alias}
title=${color.alias}
value=${color.alias}
style="--uui-swatch-color: var(${color.varName})">
</uui-color-swatch>
`,
)
}
</uui-color-swatches>
<hr />
${this.renderColors()}
<uui-scroll-container id="icons">
${this.data?.showEmptyOption && !this._isSearching
? html`
Expand Down Expand Up @@ -144,9 +125,35 @@ export class UmbIconPickerModalElement extends UmbModalBaseElement<UmbIconPicker
${umbFocus()}>
<uui-icon name="search" slot="prepend" id="search_icon"></uui-icon>
</uui-input>
<hr />
Copy link

Copilot AI Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <hr /> separator after the search input should only render when colors are visible. Currently, it renders even when hideColors is true, creating an unnecessary visual separator. Move this line inside the renderColors() method before the color swatches to ensure it only appears when colors are shown.

Copilot uses AI. Check for mistakes.
`;
}

renderColors() {
return this.data?.hideColors === true
Copy link

Copilot AI Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explicit === true comparison is redundant since hideColors is already a boolean. Simplify to return this.data?.hideColors ? nothing : html\...` for cleaner code.

Suggested change
return this.data?.hideColors === true
return this.data?.hideColors

Copilot uses AI. Check for mistakes.
? nothing
: html`<uui-color-swatches
value=${ifDefined(this.value.color)}
label=${this.localize.term('defaultdialogs_colorSwitcher')}
@change=${this.#onColorChange}>
${
// TODO: Missing localization for the color aliases. [NL]
this._colorList.map(
(color) => html`
<uui-color-swatch
label=${color.alias}
title=${color.alias}
value=${color.alias}
style="--uui-swatch-color: var(${color.varName})">
</uui-color-swatch>
`,
)
}
</uui-color-swatches>
<hr />
`;
}

renderIcons() {
return this._iconsFiltered
? repeat(
Expand Down
1 change: 1 addition & 0 deletions ...eb.UI.Client/src/packages/core/icon-registry/icon-picker-modal/icon-picker-modal.token.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { UmbModalToken } from '@umbraco-cms/backoffice/modal';
export interface UmbIconPickerModalData {
placeholder?: string;
showEmptyOption?: boolean;
hideColors?: boolean;
}

export interface UmbIconPickerModalValue {
Expand Down
6 changes: 6 additions & 0 deletions src/Umbraco.Web.UI.Client/src/packages/property-editors/icon-picker/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ export const manifests: Array<UmbExtensionManifest> = [
description: 'Icon name to show when no icon is selected',
propertyEditorUiAlias: 'Umb.PropertyEditorUi.IconPicker',
},
{
alias: 'hideColors',
label: 'Hide colors',
description: 'Hide color swatches from modal',
propertyEditorUiAlias: 'Umb.PropertyEditorUi.Toggle',
},
],
},
},
Expand Down
6 changes: 5 additions & 1 deletion ...lient/src/packages/property-editors/icon-picker/property-editor-ui-icon-picker.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,14 @@ export class UmbPropertyEditorUIIconPickerElement
@state()
private _placeholderIcon = '';

@state()
private _hideColors = false;

public set config(config: UmbPropertyEditorConfigCollection | undefined) {
if (!config) return;
const placeholder = config.getValueByAlias('placeholder');
this._placeholderIcon = typeof placeholder === 'string' ? placeholder : '';
this._hideColors = config.getValueByAlias('hideColors') as boolean;
}

private async _openModal() {
Expand All @@ -70,7 +74,7 @@ export class UmbPropertyEditorUIIconPickerElement
icon: this._icon,
color: this._color,
},
data: { placeholder: this._placeholderIcon, showEmptyOption: !this.mandatory },
data: { placeholder: this._placeholderIcon, showEmptyOption: !this.mandatory, hideColors: this._hideColors },
}).catch(() => undefined);

if (!data) return;
Expand Down
Loading