refactor to avoid potential second call to wx.App() #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice catch @ruck94301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was developing another gui dialog for a different feature,
I learned that calling wx.App() multiple times can be problematic and is strongly advised against.
Presently it's called once with creation of a registration dialog,
and once in gui_main.main_window.
Although the developers haven't seen problems with the existing implementation --
maybe because the wx.App obj used by the registration dialog is garbage collected before gui_main.main_window is run? --
it makes sense to follow wx convention, and avoid calling wx.App() twice.
This PR removes the calls in gui_main.main_window and registration.registration,
and replaces them with a single call in main.py to mywx.App(). In addition, the mywx.App function adds protection so that if it is inadvertently called multiple times, it avoids instantiating another wx.App object.