-
Notifications
You must be signed in to change notification settings - Fork 14
Replace many pylint pragmas in py-files with pylint options defined in pylintrc. #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Replace many pylint pragmas in py-files with pylint options defined in pylintrc. #331
Conversation
Instead of pylint pragmas, for now at least, use pylint command-line args and pylintrc to disable/enable some messages
No change to behavior.
|
FWIW, 26 py-files scored by pylint. This tells me I've fallen short of my goal for one of my files, mywx/custom.py (6.32). Also, approx 11 warnings for gui_app_icon.py (6.49) could be reviewed. |
This brings quality metric from 6 up to 9.
|
b22794c adds a config to pylintrc, namely, don't bother warning us about being unable to see names in AppKit. bringing its pylint score above 9. |
Months ago when I started using pylint for static analysis, I began using pylint pragmas to disable/enable some types of observations.
I'm scrubbing a lot of those now, but not all.
The ones I'm scrubbing I've reviewed and decided it's better to disable or enable globally, so I've moved them to settings in pylintrc.
Especially my attempt to be very specific with disabling/enabling "wrong-import-position" was futile, because pytest has a bug in the current implementation of that rule. :-/
Merging this PR will have no effect on LabGym behavior.