Бородин Георгий #16
Open
Бородин Георгий #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 17, 2017 19:07
Zhigalov
reviewed
May 19, 2017
| .url('/'); | ||
| }); | ||
|
|
||
| it('should show 0 product for ""', () => { |
Contributor
There was a problem hiding this comment.
for "" -> for empty string
А то я сначала подумал что это какой-то шаблонный тест
В интеграционных тестах принято проверять успешные сценарии
Проверь что по заданному слову будут искаться товары
| let allComments = browser.getText('div.col-lg-12>div'); | ||
| const date = browser.getText('.media-heading small')[allComments.length - 1]; | ||
|
|
||
| assert(moment(date, 'MMMM Do YYYY, h:m:s a').isValid()); |
Contributor
There was a problem hiding this comment.
В этом тесте не хватает проверки на время
| assert.equal(crumbs[0], 'Home'); | ||
| assert.equal(crumbs[1], 'Stickers'); | ||
| assert.equal(crumbs[2], 'Leaf Sticker'); | ||
| }); |
Contributor
There was a problem hiding this comment.
Хлебные крошки есть на нескольких страницах: главная, поиск, корзина и т.д.
Надо проверить все
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.