fix(agent): redesign compaction to use tree branching#19
Merged
Conversation
… bugs Compaction now forks a new branch off root instead of only modifying the in-memory message slice. This preserves the original branch, prevents the SummarizeCompactor from re-firing every iteration, and sets the compacted branch as active for subsequent Invoke calls. Additional fixes: configurable KeepLast, ToolUseContent serialization, SlidingWindow tool-pair integrity, compactNow warning, remove unused tree.Store, replace joinStrings with strings.Join.
Extract compaction logic from runLoop into tryCompact helper to bring cyclomatic complexity from 31 to under 30 (fixes CI lint failure). Add 13 tests covering persistCompacted, tryCompact, SlidingWindow tool-pair integrity, configurable KeepLast, MessagesToText with ToolUseContent, and CompactConfig round-trip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tree.Branch, adds compacted messages as nodes, and sets the new branch as active. Original branch is preserved untouched. This also eliminates the re-firing bug (new branch starts below threshold).KeepLast(was hardcoded to 4),ToolUseContentserialization inMessagesToText,SlidingWindowCompactortool-pair integrity check,compactNowno-op warning, removal of unusedtree.Store/WithStore, andjoinStrings→strings.Join.Test plan
./agent/...tests pass./rag/...tests passTestAgentWithSummarizeCompactorupdated to verify both the active (compacted) branch and the preserved main branch