feat: uplift dependencies and update to support ink-v6.0.0-alpha#143
feat: uplift dependencies and update to support ink-v6.0.0-alpha#143davidsemakula merged 20 commits intouse-ink:mainfrom
ink-v6.0.0-alpha#143Conversation
* feat: migrate to revive (issue with revive_api) * feat: migrate to revive for drink and cli * fix: format * chore: update Cargo.toml & lock file * chore: update gitignore and remove .vscode * fix: flipper example contract * chore: update lockfile * fix: example contracts * fix: cli layout constraint params & example contracts * chore: description for storage deposit limit * chore: use ink main branch * chore: resolve review comments * chore: add dummy polkavm binary * fix: call() string parameters * chore: update multiple-contracts test * chore: rename read contract code binary method * chore: add comment * chore: fix example contracts * chore: update multiple_contract test * fix: multiple contracts test * chore: resolve review comments * refactor: read_contract_binary
* chore: update dependencies to support ink v6 alpha * chore: update Cargo.lock * chore(mock): remove DrinkDebug and intercept calls * chore(examples): bump lockfile and sync ink! v6
Note to the reviewers:
|
|
drink/drink-cli/src/executor/contract.rs Lines 121 to 139 in 94835ac @chungquantin Looks like this (and may be its callers) need to be update to work with |
Fixed in 4b54e6f |
9046a40 to
57ddac2
Compare
davidsemakula
left a comment
There was a problem hiding this comment.
Thanks @chungquantin !
66119f0 to
36c91de
Compare
36c91de to
58c778c
Compare
The PR uplift all dependencies to use latest version of ink! crate (v6.0.0) and migrate all code logic to support
pallet-revive. Key critical changes made:type DebuginChainExtension, the feature to mock contract calls fail completely and requires alternative approach using tracing API to support the feature.examples/quick-start-with-drinkto test with tracing API instead of decodingdebug_message(which is removed in revive).examples/chain-extension(chain extensions are deprecated inpallet-revive) and adds todo for a similar precompile replacement.Examples Tracking
examples/contract-eventsexamples/dry-runningexamples/flipperexamples/runtime-interactionexamples/multiple-contractsexamples/quick-start-with-drinkTO BE FIXED
Aside from all TODOs and deprecated calls of
MockExtension, below issues need to be resolved:examples/cross-contract-call-tracing: Consider implement the alternative tracing approach with the new Debugging Strategiesexamples/mocking: Need to implement alternative approach withouttype DebuginChainExtensionchain-extensiontest with similar precompile test #140 |examples/chain-extension: chain extensions are deprecated and replaced with precompiles in pallet-reviveCurrent issue is theMemorytrait inpallet-reviveis required for the implementation of the chain extension but theMemorytrait is inwasmmodule which is not exported as public. In the chain extension implementation of Pop Network, we forked thepallet-reviveand modified it. Probably deprecated in the future with the introduction of precompiles.