fix: support older node resolvers #917
Closed
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a small but important backwards support update to
package.jsonfor some common node-resolvers in 3rd party utilities such aseslinteslint-plugin-importuses a custom node-resolver that doesn't support"exports"correctly, but falls back to"main"typescriptlooks at"export[].types"first and falls back to root"types"in package.json, but I recall that there was a bug in an older version of typescript where it wasn't"types"like this defined in"exports"is the correct way as per Node docs: https://nodejs.org/api/packages.html#community-conditions-definitionsMy understanding is that the default node/deno/bun resolvers, as well as for bundlers such as webpack, vite, rollup, etc, all know to prioritize
"exports"and should never fallback to"main"ever, so setting"main"the same as"default"should be of no concern. Adding"main"back in is just for backwards support of older resolvers that don't yet meet current standards