Remove PHP requirement from the IBCM simulator#99
Open
winstliu wants to merge 34 commits intouva-cs:masterfrom
Open
Remove PHP requirement from the IBCM simulator#99winstliu wants to merge 34 commits intouva-cs:masterfrom
winstliu wants to merge 34 commits intouva-cs:masterfrom
Conversation
Reading is working, running...not so much
Reset and revert are now working
winstliu
force-pushed
the
try-my-hand-at-php
branch
from
771b218 to
48d6111
Compare
This raises the browser requirement to: - Firefox 52 (March 2017) - Chrome 57 (March 2017) - Edge 16 (October 2017) - Safari 10.1 (March 2017)
winstliu
force-pushed
the
try-my-hand-at-php
branch
from
48d6111 to
a80dfc1
Compare
Author
|
Note: This was more of a fun experiment, so I won't be discouraged or anything if you don't end up merging it for Reasons, but it does work! |
|
I really like this, and plan to include it. But with the course just moving online, and there being less help available to the students as a result, I'm hesitant to change this right before the students are going to start on the lab. So I'll merge this in in a few weeks. Thanks for all your work on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The branch name no longer makes sense, as I ended up ripping out all the PHP, haha :P.
Anyway...as JavaScript has a FileReader API, we can leverage that to do all the processing locally instead of requiring a server.
Some other changes I performed along the way:
TODO