Skip to content

chore: migrate to shared ios-certificates Match repository #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

chore: migrate to shared ios-certificates Match repository #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

All notable changes to V2er iOS app will be documented in this file.

## v1.1.19 (Build XX)
1. Infrastructure: Migrate certificate management to shared ios-certificates repository
2. Improvement: Update Fastlane Match to use git@github.com:graycreate/ios-certificates.git
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] This changelog entry exposes an internal Git URL which is implementation detail that doesn't benefit end users. Consider rephrasing to focus on the user-facing benefit, such as 'Improvement: Streamlined certificate management for more reliable builds'.

Suggested change
2. Improvement: Update Fastlane Match to use git@github.com:graycreate/ios-certificates.git
2. Improvement: Streamlined certificate management for more reliable builds

Copilot uses AI. Check for mistakes.
3. Test: Verify release pipeline works with new Match repository configuration
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry includes a 'Test' item that describes testing the release pipeline. Changelog entries should describe changes delivered to end users, not internal testing activities. Consider removing this line or rephrasing it to describe the actual improvement (e.g., 'Improvement: Enhanced release pipeline reliability with updated certificate management').

Suggested change
3. Test: Verify release pipeline works with new Match repository configuration
3. Improvement: Enhanced release pipeline reliability with updated Match repository configuration

Copilot uses AI. Check for mistakes.

## v1.1.18 (Build XX)
1. Improvement: Upgrade all CI/CD workflows to use Xcode 26.0.1 (latest version)
2. Improvement: Use macOS 26 runners with Fastlane 2.228.0 for improved build performance
Expand Down
2 changes: 1 addition & 1 deletion V2er/Config/Version.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// VERSION_CODE: Build number (must always increase)

// VERSION_NAME - This is what users see (e.g., 1.1.2)
MARKETING_VERSION = 1.1.18
MARKETING_VERSION = 1.1.19

// VERSION_CODE - Internal build number (e.g., 29, 30, 31...)
CURRENT_PROJECT_VERSION = 51
2 changes: 1 addition & 1 deletion fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ platform :ios do
type: "appstore",
readonly: is_ci,
app_identifier: "v2er.app",
git_url: ENV["MATCH_GIT_URL"] || "git@github.com:graycreate/certificates-v2er-iOS.git",
git_url: ENV["MATCH_GIT_URL"] || "git@github.com:graycreate/ios-certificates.git",
keychain_name: ENV["MATCH_KEYCHAIN_NAME"] || "login.keychain",
keychain_password: ENV["MATCH_KEYCHAIN_PASSWORD"] || ""
)
Expand Down
2 changes: 1 addition & 1 deletion fastlane/Matchfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Matchfile - Configuration for code signing

# Git repository URL for storing certificates
git_url(ENV["MATCH_GIT_URL"] || "git@github.com:graycreate/certificates-v2er-iOS.git")
git_url(ENV["MATCH_GIT_URL"] || "git@github.com:graycreate/ios-certificates.git")

# Storage mode
storage_mode("git")
Expand Down
Loading