Support seeded random number generators#148
Open
julasamer wants to merge 1 commit intovadymmarkov:masterfrom
Open
Support seeded random number generators#148julasamer wants to merge 1 commit intovadymmarkov:masterfrom
julasamer wants to merge 1 commit intovadymmarkov:masterfrom
Conversation
|
Isn't the Swift random API seedable, like |
Author
|
@mrylmz: That's the API I used. You have to pass something to the |
|
Would love to have this! Would be nice to have predictably random mock data for use in tests. |
|
What ever happened here? Determinism in these tests would be amazing. I'd be happy to take another crack at this, if the only thing preventing moving forward is that it's out of date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I've added support for seeded RNG by allowing the passing of any
RandomNumberGeneratortoFaker.Caveats:
That being said, you can use this like this:
let faker = Faker(randomNumberGenerator: SomeAdvancedRandomNumberGenerator())Unfortunately, seeded RNG is somewhat hidden in iOS; my first idea was to use the RNG provided by GameKit:
We need to make
GKMersenneTwisterRandomSourceconform toRandomNumberGenerator, which is fortunately quite easy. We can then use it as the seeded RNG.However, this requires that GameKit is available. In the end, I didn't want introduce a GameKit dependency, and the whole thing is overkill anyway for my testing purposes, so I implemented a custom "RNG" which works fine for my case: