Skip to content

Improve PGP encryption security and file handling #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kmilodenisglez wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve PGP encryption security and file handling #3

kmilodenisglez wants to merge 1 commit into from

Conversation

@kmilodenisglez
Copy link

@kmilodenisglez kmilodenisglez commented Jul 7, 2025

Proposed Changes

  • Implement explicit AES-256 for symmetric encryption
  • Remove CryptographyDeprecationWarning from internal dependencies
  • Improve path handling with rsplit() to avoid name corruption
  • Simplify default path logic

Security Impact

Critical Improvement:
Explicit specification of AES-256 algorithm (vs. potentially insecure default)

Notes for Reviewers

  • Maintains ZLIB compression and SHA512 hashing
  • Does not change the interface of existing functions
  • Supports previously encrypted files

@kmilodenisglez
Improve PGP encryption security and file handling
a4ff86b 
• Explicitly enforce AES-256 symmetric encryption algorithm
• Suppress CryptographyDeprecationWarning from internal dependencies
• Robust output path handling using rsplit() for decrypted files
• Simplify default path logic using Pythonic conditional assignment
• Maintain ZLIB compression and SHA512 hashing standards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kmilodenisglez