fix: add client-side disposable email check in CLI login#188
Merged
SecurityQQ merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughadded a client-side disposable-email guard in the login flow: after email format validation the domain is normalized and checked against an in-file set of disposable domains (including subdomain matches); if matched, the function logs an error and returns null before otp is sent. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/cli/commands/login.tsx`:
- Around line 234-269: The client-side disposable domain check recreates
DISPOSABLE_DOMAINS on every login and only matches exact domains, missing
subdomains and violating camelCase rules; move the domain list into a
module-level camelCase constant (e.g., disposableDomains as a Set) so it’s
created once, and change the runtime check in the login flow (where domain is
computed from email) to treat subdomains as disposable by checking either
set.has(domain) OR testing domain.endsWith("." + candidate) for any candidate in
the Set (or normalize by stripping subdomains and checking the apex), ensuring
you reference the existing domain variable and the new disposableDomains symbol.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 04ed6fc6-4e9f-4afe-ade9-3a7fc24db107
📒 Files selected for processing (1)
src/cli/commands/login.tsx
src/cli/commands/login.tsx
Outdated
Comment on lines
+234
to
+269
| const domain = email.split("@")[1]?.toLowerCase(); | ||
| const DISPOSABLE_DOMAINS = new Set([ | ||
| "guerrillamail.com", | ||
| "guerrillamailblock.com", | ||
| "guerrillamail.net", | ||
| "guerrillamail.org", | ||
| "guerrillamail.de", | ||
| "grr.la", | ||
| "sharklasers.com", | ||
| "guerrilla.ml", | ||
| "yopmail.com", | ||
| "yopmail.fr", | ||
| "yopmail.net", | ||
| "tempmail.com", | ||
| "temp-mail.org", | ||
| "temp-mail.io", | ||
| "mailinator.com", | ||
| "mailinator2.com", | ||
| "throwaway.email", | ||
| "throwaway.email", | ||
| "trashmail.com", | ||
| "trashmail.net", | ||
| "trashmail.me", | ||
| "10minutemail.com", | ||
| "10minutemail.net", | ||
| "dispostable.com", | ||
| "maildrop.cc", | ||
| "fakeinbox.com", | ||
| "mailnesia.com", | ||
| "tempail.com", | ||
| "tempr.email", | ||
| "discard.email", | ||
| "discardmail.com", | ||
| "mohmal.com", | ||
| "burpcollaborator.net", | ||
| ]); |
Contributor
There was a problem hiding this comment.
client check misses subdomains and does extra work each call
on Line 271, Set.has(domain) only catches exact matches, so disposable subdomains can slip through client-side. also, Line 235 recreates the set every login attempt, and DISPOSABLE_DOMAINS breaks the repo’s camelCase variable rule.
suggested cleanup + stronger match
+const disposableDomains = new Set([
+ "guerrillamail.com",
+ "guerrillamailblock.com",
+ "guerrillamail.net",
+ "guerrillamail.org",
+ "guerrillamail.de",
+ "grr.la",
+ "sharklasers.com",
+ "guerrilla.ml",
+ "yopmail.com",
+ "yopmail.fr",
+ "yopmail.net",
+ "tempmail.com",
+ "temp-mail.org",
+ "temp-mail.io",
+ "mailinator.com",
+ "mailinator2.com",
+ "throwaway.email",
+ "trashmail.com",
+ "trashmail.net",
+ "trashmail.me",
+ "10minutemail.com",
+ "10minutemail.net",
+ "dispostable.com",
+ "maildrop.cc",
+ "fakeinbox.com",
+ "mailnesia.com",
+ "tempail.com",
+ "tempr.email",
+ "discard.email",
+ "discardmail.com",
+ "mohmal.com",
+ "burpcollaborator.net",
+]);
+
+const isDisposableDomain = (domain: string): boolean => {
+ if (disposableDomains.has(domain)) {
+ return true;
+ }
+ for (const blockedDomain of disposableDomains) {
+ if (domain.endsWith(`.${blockedDomain}`)) {
+ return true;
+ }
+ }
+ return false;
+};
+
async function loginWithEmail(): Promise<LoginResult | null> {
@@
- const domain = email.split("@")[1]?.toLowerCase();
- const DISPOSABLE_DOMAINS = new Set([
- ...
- ]);
+ const domain = email.split("@")[1]?.toLowerCase();
@@
- if (domain && DISPOSABLE_DOMAINS.has(domain)) {
+ if (domain && isDisposableDomain(domain)) {
log.error(
"Disposable email addresses are not allowed. Please use a permanent email address.",
);
return null;
}As per coding guidelines, "Use camelCase for variable and function names".
Also applies to: 271-271
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/cli/commands/login.tsx` around lines 234 - 269, The client-side
disposable domain check recreates DISPOSABLE_DOMAINS on every login and only
matches exact domains, missing subdomains and violating camelCase rules; move
the domain list into a module-level camelCase constant (e.g., disposableDomains
as a Set) so it’s created once, and change the runtime check in the login flow
(where domain is computed from email) to treat subdomains as disposable by
checking either set.has(domain) OR testing domain.endsWith("." + candidate) for
any candidate in the Set (or normalize by stripping subdomains and checking the
apex), ensuring you reference the existing domain variable and the new
disposableDomains symbol.
- Add module-level DISPOSABLE_DOMAINS constant (created once, not per call) - Add isDisposableDomain() helper with subdomain matching (e.g. sub.guerrillamail.com is also caught) - Lightweight inline list (~30 domains) for instant UX feedback; server-side mailchecker (55k+ domains) is the real enforcement
SecurityQQ
force-pushed
the
fix/block-disposable-emails
branch
from
0bf192d to
8a67157
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a lightweight client-side check for common disposable email domains in the CLI login flow for instant UX feedback.
Changes
/api/auth/cli/send-otpNote
This is purely a UX optimization. The real enforcement happens server-side in the
apprepo wheremailchecker(55k+ domains) blocks disposable emails at the/api/auth/cli/send-otpendpoint. This client-side check just makes the rejection faster for the most common offenders.Related PRs