feat(vector): add service loadBalancerSourceRanges field#485
Open
MrFreezeex wants to merge 1 commit intovectordotdev:developfrom
Open
feat(vector): add service loadBalancerSourceRanges field#485MrFreezeex wants to merge 1 commit intovectordotdev:developfrom
MrFreezeex wants to merge 1 commit intovectordotdev:developfrom
Conversation
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@ledger.fr>
There was a problem hiding this comment.
Pull Request Overview
Add support for specifying loadBalancerSourceRanges on both the main service and the HAProxy service so users can whitelist client IP ranges.
- Define new
loadBalancerSourceRangesfields (default[]) invalues.yaml - Render these fields in the service templates when non-empty
- Update documentation and bump chart version to 0.45.0
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/vector/values.yaml | Add default loadBalancerSourceRanges fields with explanatory comments |
| charts/vector/templates/service.yaml | Render loadBalancerSourceRanges under spec when provided |
| charts/vector/templates/haproxy/service.yaml | Render loadBalancerSourceRanges for HAProxy service when provided |
| charts/vector/README.md | Document new values and bump the version badge |
| charts/vector/Chart.yaml | Bump chart version from 0.44.0 to 0.45.0 |
Comments suppressed due to low confidence (3)
charts/vector/templates/service.yaml:23
- [nitpick] Indent this
ifblock to match the surrounding two-space indentation for consistency and to avoid template parsing issues.
{{- if .Values.service.loadBalancerSourceRanges }}
charts/vector/templates/haproxy/service.yaml:19
- [nitpick] Align the indentation of this
ifblock with the other service template blocks to maintain consistent formatting.
{{- if .Values.haproxy.service.loadBalancerSourceRanges }}
charts/vector/templates/service.yaml:23
- Consider adding Helm chart tests or unit tests to verify that
loadBalancerSourceRangesrenders correctly when populated and omitted when empty.
{{- if .Values.service.loadBalancerSourceRanges }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
loadBalancerSourceRangesfield on service to be able to whitelist traffic client traffic by IP