Add generic NoSchedule toleration to vector-agent DaemonSet for improved scheduling on tainted nodes#503
Open
AliAhsan12 wants to merge 1 commit intovectordotdev:developfrom
Conversation
- Add toleration with effect: NoSchedule, operator: Exists - Ensures DaemonSet can schedule on all tainted nodes - Maintains backward compatibility with existing master node toleration - Addresses log collection gaps in production environments
pront
reviewed
Oct 27, 2025
Comment on lines
+159
to
+160
| - effect: NoSchedule | ||
| operator: Exists |
Member
There was a problem hiding this comment.
Can we make this configurable and preserve existing behavior?
Author
There was a problem hiding this comment.
Thanks @pront understood, but since the Vector Agent is a DaemonSet meant to run on every node, making this optional would reintroduce the same scheduling issue on tainted nodes. The generic NoSchedule toleration is safe, backward-compatible, and standard across major DaemonSets like Cilium, Fluent Bit, Datadog etc. I’ve worked with several open source tools, and this is their default behavior to ensure consistent coverage across all nodes, i believe it should stay enabled by default here as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Summary
This PR adds a generic
NoScheduletoleration to thevector-agentDaemonSet to ensure Vector Agent can be scheduled on nodes with taints, addressing a critical gap in log collection from tainted nodes in production environments.🚨 Problem Statement
Currently, the
vector-agentchart only includes a specific toleration fornode-role.kubernetes.io/masternodes. This creates a significant operational issue:NoScheduletaints🔧 Solution
Add a generic toleration that allows the DaemonSet to schedule on any node with
NoScheduletaints:📊 Impact & Benefits
✅ Checklist