feat(vector): add emptyConfig and configSidecar parameter to enable dynamic vector configuration by label#523
Open
jusch23 wants to merge 1 commit intovectordotdev:developfrom
Conversation
Author
Contributor
|
Tagging @vectordotdev/vector here. Pront is on leave at the moment and I've been less involved day-to-day. Apologies for the delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The emptyConfig and configSidecar parameters have been added to enable dynamic vector configuration by label (#522).
The emptyConfig parameter provides the ability to start vector with an empty configuration directory instead of the chart's default configMap.
configSidecar uses k8s-sidecar (https://github.com/kiwigrid/k8s-sidecar) to watch for vector configurations by a given label. Enabling the sidecar container adds the flags '--allow-empty-config' and '--watch-config' to the vector argument list. The first flag is needed to start vector without any configuration file, while the second flag ensures that vector is reloaded when new configurations are added to the configuration directory.