feat(vector): Include log format support#528
Open
lazam wants to merge 1 commit intovectordotdev:developfrom
Open
feat(vector): Include log format support#528lazam wants to merge 1 commit intovectordotdev:developfrom
lazam wants to merge 1 commit intovectordotdev:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chart currently only supports
log levelwhich means that it needs to change thelog formatvia env vars instead of the same manner as level. This PR supports the change in log format via this chart. The only challenge is that it is a breaking change due to the naming convention. I thought to uselogFormatto have it backwards compatibile but it is beneficial to have them under a single mapping/section.