Skip to content

fix(vector): use dedicated annotations for headless service#536

Open
iarlyy wants to merge 1 commit intovectordotdev:developfrom
iarlyy:fix/service-headless-annotations
Open

fix(vector): use dedicated annotations for headless service#536
iarlyy wants to merge 1 commit intovectordotdev:developfrom
iarlyy:fix/service-headless-annotations

Conversation

@iarlyy
Copy link
Contributor

@iarlyy iarlyy commented Mar 2, 2026

Context:
The headless Service template uses service.annotations. This means any annotations set on the main Service leak into the headless Service, which causes conflicts with controllers such as the AWS LBC trying to reconcile a Service with load balancer config.

Proposed changes:

  • serviceHeadless gets its own annotations

Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @iarlyy, thank you for the PR. Is this a breaking change for users who currently rely on service.annotations applying to both services?

@iarlyy
Copy link
Contributor Author

iarlyy commented Mar 2, 2026

Hi @iarlyy, thank you for the PR. Is this a breaking change for users who currently rely on service.annotations applying to both services?

Hi @pront,

yes, this is a breaking change from the point of view that existing annotations will be removed if the user doesn't define them under the serviceHeadless config, though I don't expect anything around vector itself to be impacted.

Wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants