fix(vector): use dedicated annotations for headless service#536
Open
iarlyy wants to merge 1 commit intovectordotdev:developfrom
Open
fix(vector): use dedicated annotations for headless service#536iarlyy wants to merge 1 commit intovectordotdev:developfrom
iarlyy wants to merge 1 commit intovectordotdev:developfrom
Conversation
Contributor
Author
Hi @pront, yes, this is a breaking change from the point of view that existing annotations will be removed if the user doesn't define them under the Wdyt? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
The headless Service template uses
service.annotations. This means any annotations set on the main Service leak into the headless Service, which causes conflicts with controllers such as the AWS LBC trying to reconcile a Service with load balancer config.Proposed changes: