chore(ci): remove custom install-protoc.sh script#24900
chore(ci): remove custom install-protoc.sh script#24900
Conversation
github-actions
bot
added
the
domain: ci
pront
changed the title
pront
added
the
no-changelog
pront
force-pushed
the
pront-protoc-installation-linux-unify
branch
2 times, most recently
from
7796c4c to
71bb389
Compare
Adds protoc as a selectable module in prepare.sh, consolidating protoc installation alongside other dev tools. Installs via apt-get on Linux and brew on macOS, replacing the separate install-protoc.sh script. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pront
force-pushed
the
pront-protoc-installation-linux-unify
branch
from
71bb389 to
1338dc6
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1338dc6215
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if contains_module protoc; then | ||
| if ! command -v protoc &>/dev/null; then | ||
| if [[ "$(uname)" == "Linux" ]]; then | ||
| $SUDO apt-get install -y protobuf-compiler |
There was a problem hiding this comment.
The new Linux branch installs protobuf-compiler with apt-get install but never runs apt-get update, which can fail in environments that clear /var/lib/apt/lists (for example, tests/e2e/Dockerfile does this before invoking prepare.sh). In that case, the protoc module fails with Unable to locate package protobuf-compiler when protoc is not already present. apt-get --help explicitly describes update as the command that “Retrieve[s] new lists of packages,” so this path needs an index refresh before install.
Useful? React with 👍 / 👎.
…lation-linux-unify
1 participant
Summary
Add a
protocmodule to prepare.sh (which already manages versioned installs of all other tools) and delete custominstall-protoc.sh(which frequently fails and requires the workflow to be retried).Vector configuration
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.