docs(aws_sns sink): correct documentation to use SNS topic terminology#24958
Draft
thomasqueirozb wants to merge 1 commit intomasterfrom
Draft
docs(aws_sns sink): correct documentation to use SNS topic terminology#24958thomasqueirozb wants to merge 1 commit intomasterfrom
thomasqueirozb wants to merge 1 commit intomasterfrom
Conversation
github-actions
bot
added
domain: sinks
thomasqueirozb
changed the title
thomasqueirozb
added
the
no-changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
aws_snssink documentation was incorrectly referencing SQS configuration and terminology throughout. Thetopic_arnfield was not appearing in the live docs at all because the CUE configuration pointed to theaws_sqsgenerated config instead ofaws_sns.Vector configuration
NA
How did you test this PR?
Ran
make generate-component-docsto regenerate the component docs and verifiedtopic_arnnow appears correctly in the generatedaws_sns.cue.Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References