enhancement(stdlib): add IPv4-mapped IPv6 support to ip_cidr_contains#1614
Open
milas wants to merge 1 commit intovectordotdev:mainfrom
Open
enhancement(stdlib): add IPv4-mapped IPv6 support to ip_cidr_contains#1614milas wants to merge 1 commit intovectordotdev:mainfrom
milas wants to merge 1 commit intovectordotdev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support IPv4-mapped IPv6 addresses/ranges with
ip_cidr_contains.Example of an IPv4-mapped IPv6 address:
::ffff:192.168.1.1.Change Type
Is this a breaking change?
How did you test this PR?
Existing + new unit test cases.
Does this PR include user facing changes?
our guidelines.
(will add changelog entry after initial review / feedback)
Checklist
run
dd-rust-license-tool writeand commit the changes. More details here.I'm happy to open Vector PR later with additional examples/prose for the new cases.
References
I did not find any open issues/PRs for this already, sorry if I missed one!