Skip to content

Add beeper_enabled check to beep function #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
conradopoole wants to merge 2 commits into from
Closed

Add beeper_enabled check to beep function #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
459a398
Add beeper_enabled check to beep function
conradopoole Dec 16, 2025
9e5c09a
Add beeper enable/disable control to UI and backend
conradopoole Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions vbms32/vbms32.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,17 +61,20 @@
(defun bms-current () (- (bms-get-current)))

(defun beep (times dt) {
(mutex-lock buz-mutex)

(loopwhile (> times 0) {
(pwm-set-duty 0.5 0)
(sleep dt)
(pwm-set-duty 0.0 0)
(sleep dt)
(setq times (- times 1))
})
(if (= (bms-get-param 'beeper_enabled) 1)
{
(mutex-lock buz-mutex)

(loopwhile (> times 0) {
(pwm-set-duty 0.5 0)
(sleep dt)
(pwm-set-duty 0.0 0)
(sleep dt)
(setq times (- times 1))
})

(mutex-unlock buz-mutex)
(mutex-unlock buz-mutex)
})
})

(def rtc-val-magic 115)
Expand Down
37 changes: 37 additions & 0 deletions vbms32_micro/ui.qml.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ Item {
property Commands mCommands: VescIf.commands()
property ConfigParams mMcConf: VescIf.mcConfig()
property ConfigParams mCustomConf: VescIf.customConfig(0)

Component.onVisibleChanged: {
mCommands.sendCustomAppData("(send-config)");
}

ColumnLayout {
id: gaugeColumn
Expand Down Expand Up @@ -62,6 +66,14 @@ Item {
Layout.fillWidth: true
Layout.fillHeight: true
}
CheckBox {
text: "Beeper Enabled"
checkable: true
checked: mainItem.state.beeperEnabled
onClicked: {
commands.sendDataEnableBeeper(checked);
}
}
Rectangle {
Layout.fillWidth: true
Layout.preferredHeight: 2
Expand All @@ -84,4 +96,29 @@ Item {
}
}
}

Connections {
id: commands
target: mCommands

function sendDataEnableBeeper(value) {
mCommands.sendCustomAppData("(beeper-enabled " + value + ")");
}

function onCustomAppDataReceived(data) {
var str = data.toString()

if (str.startsWith("settings")) {
var tokens = str.split(" ")
mainItem.state.beeperEnabled = (Number(tokens[1])) ? true : false
}
}
}

property var state: QtObject {
id: state

property bool beeperEnabled: true
}

}
37 changes: 27 additions & 10 deletions vbms32_micro/vbms32_micro.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
(soc . 0.5)
(charge-fault . false)
(updated . false)
(beeper-en . true)
))

(def is-bal false)
Expand Down Expand Up @@ -84,24 +85,38 @@ loopwhile-thd
(defun bms-current () (* (bms-get-current) -0.2))

(defun beep (times dt) {
(mutex-lock buz-mutex)

(loopwhile (> times 0) {
(pwm-set-duty 0.5 0)
(sleep dt)
(pwm-set-duty 0.0 0)
(sleep dt)
(setq times (- times 1))
(if (assoc rtc-val 'beeper-en)
{
(mutex-lock buz-mutex)

(loopwhile (> times 0) {
(pwm-set-duty 0.5 0)
(sleep dt)
(pwm-set-duty 0.0 0)
(sleep dt)
(setq times (- times 1))
})

(mutex-unlock buz-mutex)
})
})

(mutex-unlock buz-mutex)
(defun beeper-enabled (enabled) {
(setassoc rtc-val 'beeper-en enabled)
})

(def rtc-val-magic 115)
(defun send-config () {
(var config-string "settings ")
(setq config-string (str-merge config-string (if (assoc rtc-val 'beeper-en) "1" "0")))
(send-data config-string)
})

(def rtc-val-magic 116)

; If in deepsleep, this will return 4
; (bms-direct-cmd 1 0x00)


; Exit deepsleep
; (bms-subcmd-cmdonly 1 0x000e)

Expand Down Expand Up @@ -820,6 +835,7 @@ loopwhile-thd
(setq bal-ok true)
(setq bal-ok false)
))
((event-data-rx ? data) (eval (read data)))
(_ nil)
;((? a) (print a))
)))
Expand Down Expand Up @@ -903,6 +919,7 @@ loopwhile-thd
(event-enable 'event-bms-reset-cnt)
(event-enable 'event-bms-force-bal)
(event-enable 'event-bms-zero-ofs)
(event-enable 'event-data-rx)

(set-bms-val 'bms-cell-num cell-num)
(set-bms-val 'bms-can-id (can-local-id))
Expand Down
2 changes: 1 addition & 1 deletion vbms32_micro/version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.0.1
1.0.2
15 changes: 9 additions & 6 deletions vbms_harmony16/harmony16.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,15 @@ loopwhile-thd
(defun bms-current () (* (bms-get-current) -2.0))

(defun beep (times dt) {
(loopwhile (> times 0) {
(pwm-set-duty 0.5 0)
(sleep dt)
(pwm-set-duty 0.0 0)
(sleep dt)
(setq times (- times 1))
(if (= (bms-get-param 'beeper_enabled) 1)
{
(loopwhile (> times 0) {
(pwm-set-duty 0.5 0)
(sleep dt)
(pwm-set-duty 0.0 0)
(sleep dt)
(setq times (- times 1))
})
})
})

Expand Down
15 changes: 9 additions & 6 deletions vbms_harmony32/harmony32.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,15 @@ loopwhile-thd
(defun bms-current () (* (bms-get-current) -2.0))

(defun beep (times dt) {
(loopwhile (> times 0) {
(pwm-set-duty 0.5 0)
(sleep dt)
(pwm-set-duty 0.0 0)
(sleep dt)
(setq times (- times 1))
(if (= (bms-get-param 'beeper_enabled) 1)
{
(loopwhile (> times 0) {
(pwm-set-duty 0.5 0)
(sleep dt)
(pwm-set-duty 0.0 0)
(sleep dt)
(setq times (- times 1))
})
})
})

Expand Down