VBMS32-micro beeper enable/disable pkg only #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a checkbox in the UI to enable or disable the beeper, synchronizing its state with the backend via custom app data. Updates the backend to handle beeper state, send configuration to the UI, and process related events. Bumps version to 1.0.2.
The Makefile now injects BUILD_DATE and GIT_COMMIT into ui.qml using gdate and git. The UI displays the build date and git commit hash, improving traceability of builds.
Owner
|
Looks good to me, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to vedderb/vesc_express#71 and #71 I implemented the ability to disable or enable the beeper at the QML/LISP level only, without relying on changes to the VESC Express FW.
I only pushed the changes to the micro package for now.
Is this more inline with what you proposed we do in vedderb/vesc_express#71