Skip to content

Conversation

@milliams
Copy link
Contributor

@milliams milliams commented Oct 2, 2025

Description

In #29 I added some new fields to the parser, but mistakenly missed adding them to the serialiser. This PR adds them, along with a roundtrip test.

Type of change

Please select relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the contribution guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I formatted the code with cargo fmt
  • I checked my code using cargo clippy and reports no warnings
  • I have added tests that prove my fix is effective or that my feature works
  • The changes I've made are Windows, MacOS, Linux compatible (or I've handled them using cfg target_os)
  • I increased or maintained the code coverage for the project, compared to the previous commit

Acceptance tests

wait for a project maintainer to fulfill this section...

  • regression test: ...

Add AddKeysToAgent, ForwardAgent and ProxyJump to
the serialiser.
@cocogitto-bot
Copy link

cocogitto-bot bot commented Oct 2, 2025

✔️ fa70400...ff9ca19 - Conventional commits check succeeded.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 18191086872

Details

  • 39 of 46 (84.78%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 89.848%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/serializer.rs 18 25 72.0%
Totals Coverage Status
Change from base Build 18004877766: -0.09%
Covered Lines: 2301
Relevant Lines: 2561

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants