Skip to content

Obsolete changes :(#2

Open
runephilosof wants to merge 39 commits intovejlebib:7.x-1.xfrom
odensecentralbibliotek:7.x-1.x
Open

Obsolete changes :(#2
runephilosof wants to merge 39 commits intovejlebib:7.x-1.xfrom
odensecentralbibliotek:7.x-1.x

Conversation

@runephilosof
Copy link

You might want to add some of these changes, although it would have to done manually since our repositories have diverged a tad too much.

impara and others added 27 commits January 29, 2013 09:31
Double borders and illogical styling removed.
Inherited styles from jquery ui overwritten.
Conflicts:
	css/ding_tabroll.css
To avoid changing image size.
Conflicts:
	css/ding_tabroll.css
It is required to have a label.
@oc-aegir oc-aegir force-pushed the 7.x-1.x branch 2 times, most recently from f76be1a to 68f9292 Compare November 26, 2014 13:31
@impara impara force-pushed the 7.x-1.x branch 10 times, most recently from 9b6c0f6 to f47dafd Compare October 29, 2015 09:24
@holt83
Copy link
Member

holt83 commented Nov 23, 2016

@runephilosof Thanks for the PR, but we don't use this code anymore.

We use the ding_tabroll code from the consolidated repository: https://github.com/vejlebib/ding2/tree/vejlebib/modules/ding_tabroll

As you can see by looking at the history, there has also been alot of developement on the module in DDB regi. You won't see the all the changes there because of the technique we used to migrate the code into the consolidated repo. For a full picture also look at: https://github.com/ding2/ding_tabroll

Maybe you could make a PR with your changes against https://github.com/ding2/ding2?

I can see from the commits that you've added the possibilty for external linking. This is also done in our version, but you might have some other fixes and enhancements, that DDB libraries could benefit from.

@impara impara force-pushed the 7.x-1.x branch 3 times, most recently from a2aa173 to e9e1c79 Compare December 5, 2016 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants