Adding contiguous deletion from the middle of a list and scrolling to highlighted token#67
Open
kwgithubusername wants to merge 24 commits intovenmo:masterfrom
Open
Adding contiguous deletion from the middle of a list and scrolling to highlighted token#67kwgithubusername wants to merge 24 commits intovenmo:masterfrom
kwgithubusername wants to merge 24 commits intovenmo:masterfrom
Conversation
…crolling to highlighted token
Contributor
|
Thanks for the nice fixes @woudini and sorry for the delay! I’ll take a look. 👓 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current version, deletion from the middle of a list moves the cursor back to the end. Starting at line 601 I added tracking for the token prior to the token being deleted only when deletion is occurring in the middle of the list. This tracking is lost when the scrollView.contentSize has to shrink in height, so I added a method to re-highlight the appropriate token when this shrink occurs.
Unfortunately, this feature isn't too helpful for extra large lists since the scrollView keeps scrolling to the end after each deletion, so I also added a feature for scrolling to the highlighted token so you could see what you were deleting in the middle of the list. Both of these features have passed testing.
EDIT: As of 5/14 this afternoon the latest commit works smoothly with no problems. I also added focusInputTextField to shouldChangeCharactersInRange so that the user will always be able to see what is being typed.