Delegate for return key when not completing token#92
Open
mjarvis wants to merge 1 commit intovenmo:masterfrom
Open
Delegate for return key when not completing token#92mjarvis wants to merge 1 commit intovenmo:masterfrom
mjarvis wants to merge 1 commit intovenmo:masterfrom
Conversation
When the user has the VENTokenField focused, and only has completed tokens, or no text at, tapping the return key now calls a new delegate method `tokenFieldDidReturn:`. This is useful for the user to confirm entry of tokens, allowing the app to move focus to another text field or view. `tokenField:didEnterText:` functionality has no change, and the code is written such that these two delegate methods are never called simultaneously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user has the VENTokenField focused, and only has completed tokens, or no text at, tapping the return key now calls a new delegate method
tokenFieldDidReturn:.This is useful for the user to confirm entry of tokens, allowing the app to move focus to another text field or view.
tokenField:didEnterText:functionality has no change, and the code is written such that these two delegate methods are never called simultaneously.I'm not at all certain that the naming of this delegate method is correct. Please feel free to suggest alternatives.