feat: return errors for missing/zero-dimension elements in selector screenshots#942
Open
mvanhorn wants to merge 1 commit intovercel-labs:mainfrom
Open
Conversation
…creenshots When `screenshot @ref output.png` targets an element that can't be found or has zero dimensions, return a clear error instead of silently falling back to a full-page screenshot. Closes vercel-labs#587
Contributor
|
@mvanhorn is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
screenshot @ref output.pngtargets an element that can't be found or has zero dimensions, return a clear error instead of silently falling back to a full-page screenshot.Changes
In
cli/src/native/screenshot.rs, the selector branch now uses amatchinstead ofif let Some:Nonefromget_rect_for_selectorreturns:"Element '{selector}' not found or not visible on the page""Element '{selector}' has zero dimensions ({width}x{height})"Why this matters
The element screenshot clipping already works correctly when the element is found (screenshot.rs:202-218). The gap is that a missing element silently produces a full-page screenshot, which is confusing in automation pipelines where you expect either the element's screenshot or an error.
#587 - 5 reactions, highest of any open feature request.
Testing
screenshot output.png- full page (unchanged)screenshot @e3 element.png- captures element bounding box (unchanged, already worked)screenshot @nonexistent out.png- now returns error instead of full-page fallbackCloses #587
This contribution was developed with AI assistance (Claude Code).