remove CJS exports #9687
Draft
remove CJS exports #9687
+915
−976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
force-pushed
the
9387-experiment-for-v6-beta-remove-commonjs-and-zod-3
branch
from
aa5baf9 to
84fb460
Compare
gr2m
commented
Oct 20, 2025
| "build:watch": "pnpm clean && tsup --tsconfig tsconfig.build.json --watch", | ||
| "clean": "rm -rf dist *.tsbuildinfo", | ||
| "lint": "eslint \"./**/*.ts*\"", | ||
| "lint": "eslint \"./**/*.{ts,tsx}\"", |
There was a problem hiding this comment.
ignores .tsbuildinfo files
gr2m
commented
Oct 20, 2025
| "tsup": "^7.2.0", | ||
| "typescript": "5.8.3", | ||
| "vitest": "^3.0.0", | ||
| "vitest": "^3.2.4", |
There was a problem hiding this comment.
fixes a problem with Node 24
gr2m
commented
Oct 20, 2025
| @@ -1,14 +1,16 @@ | |||
| import { defineConfig } from 'tsup'; | |||
| import packageJson from './package.json'; | |||
There was a problem hiding this comment.
Hm this should have been
import packageJson from './package.json' with { type: 'json' };instead of the dynamic async import below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9681