Fix restrict url proxying to a fixed upstream host#3
Open
kochrac wants to merge 2 commits intovercel:mainfrom
Open
Fix restrict url proxying to a fixed upstream host#3kochrac wants to merge 2 commits intovercel:mainfrom
kochrac wants to merge 2 commits intovercel:mainfrom
Conversation
Contributor
|
@kochrac is attempting to deploy a commit to the Esteban Team on Vercel. A member of the Team first needs to authorize it. |
kochrac
commented
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing this requires ensuring that the URL used in
fetchis derived only from validated components, not directly from raw user input. That means: parse the user-provided URL, verify its scheme, hostname, (optionally) port and path against strict rules and an allow‑list, then either (a) reject the request if any constraint fails, or (b) build a canonical upstream URL string from the validatedURLobject instead of the original string.For this specific code, the best fix without changing desired functionality is:
const parsed = new URL(url);).parsed.protocolishttp:orhttps:(reject others).parsed.hostnamematches the allow‑list (vidgen.x.ai).parsed.toString()(orparsed.href) as the argument tofetch, not the originalurlstring, so that the sink depends on the validated object.fetchcall.All required changes are confined to
app/api/video-proxy/route.ts, around the existing validation at lines 13–22 and thefetch(url)at line 25.