-
Notifications
You must be signed in to change notification settings - Fork 616
Bump turbo from 2.5.8 to 2.6.0 #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 Build Fix:
The Next.js 16 route handler requires a second context parameter but the getFlags function signature only accepts a request parameter, causing a TypeScript compilation error.
View Details
📝 Patch Details
diff --git a/apps/app/app/.well-known/vercel/flags/route.ts b/apps/app/app/.well-known/vercel/flags/route.ts
index fc37fc3..4283f91 100644
--- a/apps/app/app/.well-known/vercel/flags/route.ts
+++ b/apps/app/app/.well-known/vercel/flags/route.ts
@@ -1,3 +1,3 @@
import { getFlags } from "@repo/feature-flags/access";
-export const GET = getFlags;
+export const GET = (request: any, _context?: any): Promise<Response> => getFlags(request);
Analysis
Next.js 16 route handler signature incompatibility causes TypeScript compilation failure
What fails: TypeScript compiler fails on apps/app/app/.well-known/vercel/flags/route.ts due to Next.js 16.0.0 route handler signature change
How to reproduce:
cd apps/app && pnpm run buildResult:
Type error: Type 'typeof import("/vercel/path0/apps/app/app/.well-known/vercel/flags/route")' does not satisfy the constraint 'RouteHandlerConfig<"/.well-known/vercel/flags">'.
Types of property 'GET' are incompatible.
Type '(request: NextRequest) => Promise<NextResponse<null> | NextResponse<ApiData>>' is not assignable to type '(request: NextRequest, context: { params: Promise<{}>; }) => void | Response | Promise<void | Response>'.
93839c3 to
9a412c3
Compare
Bumps [turbo](https://github.com/vercel/turborepo) from 2.5.8 to 2.6.0. - [Release notes](https://github.com/vercel/turborepo/releases) - [Changelog](https://github.com/vercel/turborepo/blob/main/release.md) - [Commits](vercel/turborepo@v2.5.8...v2.6.0) --- updated-dependencies: - dependency-name: turbo dependency-version: 2.6.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
9a412c3 to
6eb9f5e
Compare
Bumps turbo from 2.5.8 to 2.6.0.
Release notes
Sourced from turbo's releases.
... (truncated)
Commits
f601651publish 2.6.0 to registry0f63f6erelease(turborepo): 2.5.9-canary.11 (#11030)dc16ef4feat: Add support for custom microfrontends.json naming (#11022)f226417feat(microfrontends): schema.json for microfrontends.json (#11008)515c47dfix: path validation inmicrofrontends.json(#11006)b74f3b1ci(fix): dynamically set ports in proxy integration tests (#11009)f3c735bdocs: Clarify passtrhough args cache miss (#11026)94adf33examples: Upgrade core-team-maintained examples to Next.js 16 (#11014)97668feci: conventional commits adjustment (#11015)1cb78e2release(turborepo): 2.5.9-canary.10 (#11001)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)