feat: integrate react-shiki into streamdown #236
Draft
+596
−224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reamdown First working draft - all package tests pass, not yet tested on website or elsewhere
react-shiki doesn't handle lang loading bc passing custom highlighter bypasses it's lang resolution
Commit 23d8efe introduced the if (!isCopied) guard to fix onCopy being called multiple times. This commit preserves that guard and removes the unnecessary useEffect cleanup pattern. React 18+ handles unmounted state updates safely, and effects aren't needed for event handler timeouts. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
- Add isAnimating prop and StreamdownRuntimeContext for streaming UX - Replace harden-react-markdown with rehype-harden plugin system - Export defaultRehypePlugins and defaultRemarkPlugins for customization - Add useRef timeout cleanup to prevent memory leaks - Disable copy/download buttons during streaming - Update test apps and website to use isAnimating prop - All 258 tests passing with react-shiki simplifications preserved Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Contributor
|
@AVGVSTVS96 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Draft – needs rebase
Will update shortly, opening now as reference
Integrates react-shiki into streamdown.
Type of Change
Related Issues
Fixes #
Closes #
Related to #
Changes Made
Testing
Test Coverage
Screenshots/Demos
Checklist
pnpm changeset)Changeset
Additional Notes