Implement changes for Combine, Resolve, ofType, README & minor clean-up#22
Merged
AlexJSully merged 1 commit intomainfrom Jul 15, 2025
Merged
Implement changes for Combine, Resolve, ofType, README & minor clean-up#22AlexJSully merged 1 commit intomainfrom
Combine, Resolve, ofType, README & minor clean-up#22AlexJSully merged 1 commit intomainfrom
Conversation
GitOrigin-RevId: 25701006c81810ee439e15793fb746596114c406
There was a problem hiding this comment.
Pull Request Overview
This PR implements new FHIRPath functions (combine, resolve, ofType), adds helper methods for FHIR resources (UnversionedProfileStrings, GetExtensions), updates README examples, and includes various minor clean-ups.
- Introduce
UnversionedProfileStringsandGetExtensionshelpers with corresponding tests. - Implement
ofType,combine, andresolveFHIRPath functions along with comprehensive tests. - Update README usage examples to reference
fhirpath.Resourceand tweak minor comments and workflow scripts.
Reviewed Changes
Copilot reviewed 44 out of 46 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/resource/resource.go | Added UnversionedProfileStrings and GetExtensions methods |
| internal/resource/resource_test.go | Added tests for UnversionedProfileStrings and extension retrieval |
| fhirpath/internal/funcs/impl/combine.go | Implemented Combine FHIRPath function |
| fhirpath/internal/funcs/impl/resolve.go | Implemented Resolve FHIRPath function |
| fhirpath/internal/funcs/impl/filtering.go | Implemented OfType FHIRPath function |
| README.md | Updated examples to use fhirpath.Resource |
| .github/workflows/pr-check.yaml | Expanded PR author sed pattern |
Comments suppressed due to low confidence (3)
.github/workflows/pr-check.yaml:38
- The shell test is missing a space before the closing bracket, causing a syntax error. Change it to
if [ -z "$body" ]; then.
if [ -z "$body"]; then
fhirpath/internal/funcs/impl/combine.go:11
- [nitpick] Update the documentation to reflect that the combined collection preserves the order of the input and the provided arguments (deterministic order).
// There is no expectation of order in the resulting collection.
fhirpath/internal/parser/visitor.go:254
- [nitpick] Add a check to ensure
v.Functions["ofType"]exists to avoid a panic if the key is missing, e.g. usefn, ok := v.Functions["ofType"]; if !ok { /* error */ }.
case expr.Inequivalence:
bitwizeshift
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including the following changes:
Combinemethod by @AlexJSullyResolvemethod by @vihang-mofTypefrom PR Implement ofType() #20 by @Quarz0GitOrigin-RevId: 25701006c81810ee439e15793fb746596114c406