Conversation
wsnyder
left a comment
There was a problem hiding this comment.
Thanks. Using a personal Verilator branch, edit ci/ci-install.bash to point to your branch with this change, and make sure all tests pass on all platforms. I'm especially worried about Windows.
|
I'm with you that adding more system calls may run into complications on Windows. However, I don't think I'd suggest getting |
|
Yes, a pull to add here all of the same runner flavors as we use on Verilator would be appreciated. It was just that no one got to it. |
|
Thanks for the CI tests, please merge master into this, add a test, and once passes will be good to merge. |
|
As predicted, this doesn't play nice with Windows. And based on my limited research, there's not a direct analogue to unix fifos in Windows. So I'm just leaving this as a non-Windows thing for now. |
vcddiff currently only works on seekable files. That means while this obviously has no diffs:
this (incorrectly) does:
and more importantly so does:
This is not ideal for very large VCDs. We could instead make temporary files and open them instead but that's less ideal for cases which do reasonably fit in memory. In any case, this is less surprising than getting a diff between a file and itself.