Skip to content

Fix for when user scrolls content quickly results in content not being loaded #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
x2rider wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for when user scrolls content quickly results in content not being loaded #185

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2210fd9
Fix when scrolling pages too quickly causes content to not be displayed
Jul 29, 2016
7c783d4
Merge https://github.com/vfr/Reader
Dec 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Sources/ReaderViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,11 @@ - (void)handleScrollViewDidEnd:(UIScrollView *)scrollView
}
];

// If a person scrolls very fast, the call to draw the content is never called.
// this will check to see if the current page is in contentViews, and if not, call it to be displayed
if(!CFArrayContainsValue((__bridge CFArrayRef)contentViews.allKeys, CFRangeMake(0, [contentViews.allKeys count]), (CFNumberRef)document.pageNumber))
[self layoutContentViews:scrollView];

[mainToolbar setBookmarkState:[document.bookmarks containsIndex:page]];

[mainPagebar updatePagebar]; // Update page bar
Expand Down