Skip to content

feat: for customize transforming the segment response data #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DreamSkyOk wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: for customize transforming the segment response data #1572

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf821ca
feat: for customize transforming the segment response data
DreamSkyOk Mar 20, 2025
b7740b1
Simplify customization segment response logic
DreamSkyOk Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/media-segment-request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,15 +317,22 @@ const handleSegmentResponse = ({
return finishProcessingFn(errorObj, segment);
}
triggerSegmentEventFn({ type: 'segmentloaded', segment });
const newBytes =

let newBytes;
// because the 'response' property from XMLHttpRequest is readonly,
// can add customize read-write 'videojsCustomizedResponse' property to request object via the onResponse method.
if (('videojsCustomizedResponse' in request) && request.videojsCustomizedResponse) {
newBytes = request.videojsCustomizedResponse;
} else {
// although responseText "should" exist, this guard serves to prevent an error being
// thrown for two primary cases:
// 1. the mime type override stops working, or is not implemented for a specific
// browser
// 2. when using mock XHR libraries like sinon that do not allow the override behavior
(responseType === 'arraybuffer' || !request.responseText) ?
newBytes = (responseType === 'arraybuffer' || !request.responseText) ?
request.response :
stringToArrayBuffer(request.responseText.substring(segment.lastReachedChar || 0));
}

segment.stats = getRequestStats(request);

Expand Down