perf(Game/IGame): speedup multiplication theorems#294
Open
plp127 wants to merge 8 commits intovihdzp:masterfrom
Open
perf(Game/IGame): speedup multiplication theorems#294plp127 wants to merge 8 commits intovihdzp:masterfrom
plp127 wants to merge 8 commits intovihdzp:masterfrom
Conversation
vihdzp
reviewed
Jan 6, 2026
Contributor
Author
|
The |
Owner
|
I'd personally feel sad replacing a succinct proof for a fifteen-line case bash in favor of like two seconds of build-time. But if you can find terse proofs (or proofs that are no worse) that are faster, then that's obviously a net positive. |
vihdzp
requested changes
Jan 7, 2026
Owner
vihdzp
left a comment
There was a problem hiding this comment.
I'm not all too sure how I feel about mul_eq'' having a "manual proof", to be honest. I'll leave the decision of merging this up to @tristan-f-r.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speedup multiplication theorems in
Game/IGameI measured
private theorem mul_comm'goes from 1500ms to 50msprivate theorem neg_mul'goes from 1000ms to 220ms