Set spatial_refs to none after generate_reasoning #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EthanReid
changed the title
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where spatial_refs were incorrectly passed to generate_answer in reasoning mode. The spatial references are consumed during the reasoning phase when processing spatial tokens, but were not being cleared before the answer generation phase, causing a mismatch between the prompt tokens (which no longer contain spatial token placeholders) and the spatial_refs parameter.
Key Change
- Sets
spatial_refs = Noneafter the reasoning phase completes to prevent them from being incorrectly passed to the answer generation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reasoning mode
spatial_refsdid not work. We were passing thespatial_refsto generate_answer even when the prompt was suffix only as we has already consumed the prompt with the spatial tokens duringgenerate_reasoning. Solution is to set thespatial_refsto none after consuming them.