Skip to content

fix: add exception logging #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vimal-java-dev merged 1 commit into from
Apr 5, 2026
Merged

fix: add exception logging #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/main/java/com/vimaltech/contactapi/exception/GlobalExceptionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package com.vimaltech.contactapi.exception;

import com.vimaltech.contactapi.dto.ApiResponse;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.http.ResponseEntity;
import org.springframework.web.bind.MethodArgumentNotValidException;
import org.springframework.web.bind.annotation.*;
Expand All @@ -10,6 +12,8 @@
@RestControllerAdvice
public class GlobalExceptionHandler {

private static final Logger log = LoggerFactory.getLogger(GlobalExceptionHandler.class);

@ExceptionHandler(MethodArgumentNotValidException.class)
public ResponseEntity<ApiResponse> handleValidationException(
MethodArgumentNotValidException ex) {
Expand All @@ -21,6 +25,9 @@ public ResponseEntity<ApiResponse> handleValidationException(
.map(fieldError -> fieldError.getDefaultMessage())
.orElse("Validation error");

// Optional but useful
log.warn("Validation failed: {}", errorMessage);

ApiResponse response = new ApiResponse(
false,
errorMessage,
Expand All @@ -33,6 +40,9 @@ public ResponseEntity<ApiResponse> handleValidationException(
@ExceptionHandler(Exception.class)
public ResponseEntity<ApiResponse> handleGenericException(Exception ex) {

// 🔥 CRITICAL LINE (THIS WAS MISSING)
log.error("Unhandled exception occurred", ex);

ApiResponse response = new ApiResponse(
false,
"Something went wrong. Please try again later.",
Expand Down
Loading