Skip to content

Conversation

@tvatter
Copy link
Collaborator

@tvatter tvatter commented Jun 27, 2025

Example:

rvs1 <- list(
  order = c(1L, 2L, 3L, 4L),
  struct_array = list(c(2L, 3L, 4L), c(3L, 4L), c(4L)),
  trunc_lvl = 3L,
  d = 4L
)
class(rvs1) <- c("rvine_structure", "list")

rvs2 <- list(
  order = c(5L, 6L, 7L, 8L),
  struct_array = list(c(6L, 7L, 8L), c(7L, 8L), c(8L)),
  trunc_lvl = 3L,
  d = 4L
)
class(rvs2) <- c("rvine_structure", "list")

merged <- rvinecopulib:::merge_rvine_structures(list(rvs1, rvs2))
str(merged)

@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 96.10%. Comparing base (ba50731) to head (e38bd1a).

Files with missing lines Patch % Lines
src/vinecopulib-interface.cpp 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #313      +/-   ##
==========================================
- Coverage   96.93%   96.10%   -0.84%     
==========================================
  Files          16       16              
  Lines        1830     1848      +18     
==========================================
+ Hits         1774     1776       +2     
- Misses         56       72      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tvatter
Copy link
Collaborator Author

tvatter commented Jul 30, 2025

Theresa suggested that the following doesn't work

set.seed(1)
struct_1 = rvine_structure_sim(5)

struct_2 = rvine_matrix_sim(3)
struct_2[struct_2 > 0] = struct_2[struct_2 > 0] + struct_1$d
struct_2 = as_rvine_structure(struct_2)


rvs1_list = list(
  order = struct_1$order,
  struct_array = struct_1$struct_array,
  trunc_lvl = struct_1$d - 1,
  d = struct_1$d
)

class(rvs1_list) <- c("rvine_structure", "list")
rvs1_list

rvs2_list = list(
  order = struct_2$order,
  struct_array = struct_2$struct_array,
  trunc_lvl = struct_2$d - 1,
  d = struct_2$d
)

class(rvs2_list) <- c("rvine_structure", "list")
rvs2_list

rvinecopulib:::merge_rvine_structures(list(rvs1_list , rvs2_list))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants