patch(): pass filename to transform func#3
Open
ShaMan123 wants to merge 4 commits intoviruscamp:masterfrom
Open
patch(): pass filename to transform func#3ShaMan123 wants to merge 4 commits intoviruscamp:masterfrom
filename to transform func#3ShaMan123 wants to merge 4 commits intoviruscamp:masterfrom
Conversation
Author
|
Also I think using Fixed by b14734f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When transforming relative files it is crucial to have the filename accessible to make decisions.
Extremely useful when using only babel + module scripts + importmaps
Changes
Passed the full filename for the state to the function.
Tried to add a test but it doesn't have the state as it does in a real call.
Also, I made the transformer skip the transformed imports.