Skip to content

Conversation

@felixpalmer
Copy link
Collaborator

Includes fix from CartoDB/quadbin-js#13

@felixpalmer felixpalmer requested a review from zbigg April 19, 2023 11:02
"moment-timezone": "^0.5.33",
"pbf": "^3.2.1",
"quadbin": "^0.1.2"
"quadbin": "^0.1.8"
Copy link
Collaborator

@VictorVelarde VictorVelarde Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there are some issues related to vite at tests

@VictorVelarde VictorVelarde self-requested a review April 19, 2023 12:14
Copy link
Collaborator

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 , but check tests

@VictorVelarde VictorVelarde self-requested a review April 19, 2023 12:42
@coveralls
Copy link

Coverage Status

Coverage: 89.911%. Remained the same when pulling 0219154 on felix/bump-quadbin into 818751a on master.

@felixpalmer felixpalmer merged commit 7fc5fce into master Apr 20, 2023
@felixpalmer felixpalmer deleted the felix/bump-quadbin branch April 20, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants