Running all tests in a suite before reporting#156
Open
evanworley wants to merge 5 commits intovisionmedia:masterfrom
Open
Running all tests in a suite before reporting#156evanworley wants to merge 5 commits intovisionmedia:masterfrom
evanworley wants to merge 5 commits intovisionmedia:masterfrom
Conversation
… if one fails. This fixes an issue where it would only report the first failure
…ethods (has multiple tests)
Author
|
Added one more fix which addresses an unchecked call to test.callback() in assertResponse. The problem is that test.callback only exists if the Test has multiple tests, otherwise it's null. The bad call to callback generates an exception which results in the http server not being shut down properly. |
added 2 commits
December 13, 2011 15:21
…llow nested assert.response calls
Author
|
Two more fixes
|
|
This would be a big help. |
Author
|
Hi Eric, It appears that expresso is mostly dead. We switched to Mocha (http://visionmedia.github.com/mocha/) a few months ago, and I'd suggest you do the same. Unless you want to maintain expresso :/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes run all the tests in a suite before reporting. Previous the first assertion failure was reported and expresso stopped running tests. I believe it is more useful to report all the failures in the test, to prevent the developer from executing the run/fix loop many times.