-
Notifications
You must be signed in to change notification settings - Fork 133
Update Silo and HDF5 #20752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Update Silo and HDF5 #20752
Conversation
|
So far looks great! I recommend we create a ticket that lists plugins that still need to use old HDF5 APIs via defines. |
| if [[ "$DO_ZLIB" == "yes" ]]; then | ||
| info "Configuring HDF5 with ZLib support." | ||
| cf_zlib="--with-zlib=\"${VISITDIR}/zlib/${ZLIB_VERSION}/${VISITARCH}\"" | ||
| cmk_opts="${cmk_opts} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see ZLIB support here, but not SZIP.
SZIP is still listed in bv_hdf5_depends_on and in bv_hdf5_host_profile. If an external szip is no longer needed for building hdf5 it should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point. I am inclined to remove the SZIP requirements here. Its never used...well, I can't say I know that for certain. Its an educated guess though that I believe with 95% confidence.
Does removing SZIP mean we wouldn't be able to visualize SZIP compressed data files? Yes and no. Yes, not without the user having to manage HDF5 external plugins...which is pretty easy. No, as long as the user has an SZIP plugin installed somewhere and they set HDF5_PLUGIN_PATH in their env. variables. Then, it should pretty much happen automagically. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts?
From me, none, I don't understand all the implications. I have only been following the build_visit settings as best as possible for builds of TP libs on Windows, so I needed to know if this was still a requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is unlikely that a user will understand they have an szip file and be able to create the lib and set up the env vars.
That said, if these files are very rare -- I am open to dropping support. Mark do you know if LLNL sim codes used szip in the past?
|
Almost certainly no. For most of its life szip was inconveniently licensed.
Truly open source alternatives for it have emerged only recently say within
the last few years.
It was closely associated with the hdf5 library however because I think
NASA had a lot of initial interest in it. And they were a big early user
and sponsor of hdf5.
My understanding is it excels mostly at integer or integer like data and
not floating point data.
So my belief is that no llnl SIM codes have ever used it.
That said it may be worth checking with Kathryn Mohror to ask if she is
aware of ever having encountered it in some of their work on SCR.
…On Mon, Dec 8, 2025, 1:24 PM Cyrus Harrison ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/tools/dev/scripts/bv_support/bv_hdf5.sh
<#20752 (comment)>:
> if [[ "$DO_ZLIB" == "yes" ]]; then
info "Configuring HDF5 with ZLib support."
- cf_zlib="--with-zlib=\"${VISITDIR}/zlib/${ZLIB_VERSION}/${VISITARCH}\""
+ cmk_opts="${cmk_opts} \
I think it is unlikely that a user will understand they have an szip file
and be able to create the lib and set up the env vars.
That said, if these files are very rare -- I am open to dropping support.
Mark do you know if LLNL sim codes used szip?
—
Reply to this email directly, view it on GitHub
<#20752 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLUUZD2QSA5W6OL6GAOGE34AXT7ZAVCNFSM6AAAAACOL3TFYOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKNJUGEZDCMRVGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I was trying to build Xdmf against the one, parallel HDF5-2.0 I have installed and that fails, even after my patches for HDF5-2.0. Why? It fails because including There are a few options for situations like this...
|
|
To get Xdmf library to add |
|
Ok, netcdf requires more love because it a) assumes I suspect HDF5-2.0 has a bug in the API mapping macros for |
|
You might try Netcdf 4.5.0. That's what I've been using on Windows (for ease of building). I had no issues with the VisIt using this version, nor with building it against HDF5 2.0 in my test builds this week. |
So, the set of patches needed for netcdf-4.1.1 (now ~15 years old) with HDF5-2.0 is getting larger and more complex. I am close to having it working but I kinda like @biagas suggestion. @cyrush do you have strong opinions? |
|
@markcmiller86 I think we should try the new version, would be good to remove ancient patches and have same code used on windows as linux if possible. |
|
So, I was 4 patches in and apparently 2 patches away from a successful netcdf-4.1.1 build with HDF5-2.0. So, I've currently got that in this PR. I will revisit the issue before taking out of draft mode. But, for time being, I think its working now. |

Description
bv_xxx.shfor some HDF5 dependent TPLsType of change
How Has This Been Tested?
Reminders:
Checklist: